Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): check paths diff within same branch on push #157

Closed

Conversation

rebornplusplus
Copy link
Member

Proposed changes

On "push" events, specify the "base" value of dorny/paths-filter action. This ensures that the comparison is made against the recent commit on that particular branch before pushing the new commits.

Previously, it was left empty, resulting in the default value which is the default branch "ubuntu-22.04". Thus pushed to the "ubuntu-24.04" branch would be compared with "ubuntu-22.04" which is a bug. [1]

This commit fixes said bug.

[1] https://github.com/canonical/chisel-releases/actions/runs/8092571514/job/22113523205#step:3:52

Testing

Expected behaviour on Push:

Expected behaviour on PRs:

Checklist

On "push" events, specify the "base" value of dorny/paths-filter action.
This ensures that the comparison is made against the recent commit on
that particular branch before pushing the new commits.

Previously, it was left empty, resulting in the default value which is
the default branch "ubuntu-22.04". Thus pushed to the "ubuntu-24.04"
branch would be compared with "ubuntu-22.04" which is a bug. [1]

This commit fixes said bug.

[1] https://github.com/canonical/chisel-releases/actions/runs/8092571514/job/22113523205#step:3:52
@rebornplusplus rebornplusplus added the Priority Look at me first label Feb 29, 2024
@rebornplusplus
Copy link
Member Author

Note that the failing tests in this PR will be fixed by #158.

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate that this works, but given that we have branch moderation, PR tests and scheduled (cron) full-release tests, I actually think it is better to just remove the push event on the ubuntu branches. makes everything simpler without sacrificing the testing. The worst thing that can happen is a delay:

  • someone with admin rights pushes directly to a branch, bypassing the rules (which shouldn't be done anyway)
  • there will be no tests running right away, but there will be the scheduled tests anyway later on

@rebornplusplus
Copy link
Member Author

Closing this in favour of #172, #173, #174 and #175. We need to open this if we ever bring back on: push workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Look at me first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants