chore(main): check paths diff within same branch on push #157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
On "push" events, specify the "base" value of dorny/paths-filter action. This ensures that the comparison is made against the recent commit on that particular branch before pushing the new commits.
Previously, it was left empty, resulting in the default value which is the default branch "ubuntu-22.04". Thus pushed to the "ubuntu-24.04" branch would be compared with "ubuntu-22.04" which is a bug. [1]
This commit fixes said bug.
[1] https://github.com/canonical/chisel-releases/actions/runs/8092571514/job/22113523205#step:3:52
Testing
Expected behaviour on Push:
Changes will be computed between recent commits before push and after push: https://github.com/rebornplusplus/chisel-releases/actions/runs/8094448190/job/22119167199 (Check the logs of "Check changed paths" step)
Expected behaviour on PRs:
Checklist