chore(22.04): add lint job #147
Conversation
There was a problem hiding this comment.
can u pls share the link to the PR or Issue that targets the validation fixes flagged in this PR?
I see #176, but let's please also track that internally with high priority (the reason for high priority is because we don't want to merge this without them, otherwise all coming future PRs would be raising these red flags, despite the user having not touched them)
|
Yeah, it is indeed #176. I created ROCKS-1033 to track it internally. I will add the fixes for the failures today actually. It should not take long. |
|
Okay, so I refactored the files for this release. The checks should now be okay. Please take a look. Also note that I would like to rebase the commits, not squash since the commits have different purposes and I want to keep a good history. So I will rebase the commits after approvals. |
rebornplusplus
force-pushed
the
ci/lint-22.04
branch
from
431a601 to
efa2991
Compare
This commit fixes the linting failures of yamllint and the custom bash script which checks whether 'essential' and 'contents' are sorted or not in a slice definition.
|
I have rebased the commits. Please do not "Squash and merge" when merging this. @cjdcordeiro |
This PR adds a "Lint" job to lint the slices and chisel.yaml. It also refactors the existing slice definition files and chisel.yaml for the lint checks to pass.