chore: fix archive version while logging #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornplusplus
changed the title
rebornplusplus
force-pushed
the
ci/install-slices/archive-version
branch
from
e2c9759 to
25cabd1
Compare
rebornplusplus
changed the title
Archive version was being changed to 23.1 instead 23.10 for values with trailing zeroes. This commit fixes the bug. https://github.com/canonical/chisel-releases/actions/runs/8014505888/job/21893215155?pr=143
cjdcordeiro
reviewed
Feb 23, 2024
| str(archive_data["version"]), archive_data["components"], archive_data["suites"] | ||
| ) | ||
| version = archive_data["version"] | ||
| if isinstance(version, float): |
There was a problem hiding this comment.
is there ever a time where this won't be a float?
There was a problem hiding this comment.
is there ever a time where this won't be a float?
I think that may happen if something encloses the version with quotes.
There was a problem hiding this comment.
Since the chisel tool expects and reads version as a string, someone can enclose it in quotes as Anas mentioned.
|
The CI tests are showing us now what we have missed in several slices because we couldn't manually test them on every architecture :) |
gregory-schiano
pushed a commit
to gregory-schiano/chisel-releases
that referenced
this pull request
Jun 24, 2024
Archive version was being changed to 23.1 instead 23.10 for values with trailing zeroes. This commit fixes the bug. https://github.com/canonical/chisel-releases/actions/runs/8014505888/job/21893215155?pr=143
clay-lake
pushed a commit
to clay-lake/chisel-releases
that referenced
this pull request
Nov 18, 2024
Archive version was being changed to 23.1 instead 23.10 for values with trailing zeroes. This commit fixes the bug. https://github.com/canonical/chisel-releases/actions/runs/8014505888/job/21893215155?pr=143
clay-lake
pushed a commit
to clay-lake/chisel-releases
that referenced
this pull request
Nov 21, 2024
Archive version was being changed to 23.1 instead 23.10 for values with trailing zeroes. This commit fixes the bug. https://github.com/canonical/chisel-releases/actions/runs/8014505888/job/21893215155?pr=143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archive version was being changed to 23.1 instead 23.10 for values with trailing zeroes. This PR fixes the bug.
https://github.com/canonical/chisel-releases/actions/runs/8014505888/job/21893215155?pr=14