Report invalid units generated during test session (bugfix) #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook25
force-pushed
the
close_session_invalid
branch
from
c7c4aae
to
9e11b88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if a template generates a unit that is invalid, a message is logged (error for some, debug for some others) and the unit is skipped. This message is visible using Checkbox local but it burried in the Agent log in remote. This is of course sub-optimal as we have no recollection of anything happening after the fact but this can lead to tests being... not executed, without an explanation or even a way for the user to notice.
This PR moves the validation at
run_jobtime, reporting the failure to the user with a clear text when the job would be executed with an explanation as to why the job wasn't executed. This also marks the job as failed (and the test run as failed), making the failure easier to find and to audit.Resolved issues
Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1629
Documentation
Pending implementation approval, I think this should be mentioned in both the extended tutorial and the normal tutorial
Tests
This implements a new metabox scenario