Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove require for rt-tests (BugFix) #1553

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Remove require for rt-tests (BugFix) #1553

merged 3 commits into from
Dec 4, 2024

Conversation

LiaoU3
Copy link
Contributor

@LiaoU3 LiaoU3 commented Oct 18, 2024

Description

Since we have package rt-tests in snapcraft and packaging, there is no need to require the package in the tests.

Resolved issues

N/A

Documentation

N/A

Tests

N/A

@pieqq
Copy link
Collaborator

pieqq commented Oct 29, 2024

Why is this removal needed? Having package.name can ensure the test runs only when that package is available (for instance, when running using a virtual environment).

@LiaoU3
Copy link
Contributor Author

LiaoU3 commented Oct 29, 2024

@pieqq It is not working on the snap version of checkbox, since we package rt-tests into the stage-packages, it is not going to be shown in the resource job package, due to the fact that package only list the debian package installed on the local.

===========[ Running job 2 / 3. Estimated time left: 1 day, 0:01:00 ]===========
[ A short-duration cyclictest to validate the system's real-time capabilities. ]
ID: com.canonical.certification::rt-performance-tests/cyclictest_rt
Category: com.canonical.certification::rt-performance-tests
Job cannot be started because:
 - resource expression "package.name == 'rt-tests'" evaluates to false
Outcome: job cannot be started
===========[ Running job 3 / 3. Estimated time left: 1 day, 0:00:00 ]===========
--[ Run cyclictest to test scheduling latency. Default run time is 24 hours. ]--
ID: com.canonical.certification::rt-performance-tests/cyclictest_rt_latency
Category: com.canonical.certification::rt-performance-tests
Job cannot be started because:
 - resource expression "package.name == 'rt-tests'" evaluates to false
Outcome: job cannot be started
(base) vincent@vincent-XPS-9320:~$ snap list checkbox24 
Name        Version      Rev  Tracking       Publisher            Notes
checkbox24  4.1.0-dev25  75   latest/stable  ce-certification-qa  -

Copy link
Collaborator

@zongminl zongminl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use snap resource job instead if this is a snap package to be checked

@pieqq
Copy link
Collaborator

pieqq commented Oct 29, 2024

Please use snap resource job instead if this is a snap package to be checked

That, or the executable resource.

@LiaoU3
Copy link
Contributor Author

LiaoU3 commented Oct 29, 2024

executable makes more sense

zongminl
zongminl previously approved these changes Nov 26, 2024
Copy link
Collaborator

@zongminl zongminl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pieqq pieqq merged commit aa97747 into canonical:main Dec 4, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants