Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use starflow #2015

Merged
merged 14 commits into from
Dec 11, 2024
Merged

build: use starflow #2015

merged 14 commits into from
Dec 11, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Dec 5, 2024

Requires #2014

This is probably best to review commit by commit, as we'll be rebasing it anyway.

@lengau lengau added the rebase label Dec 5, 2024
@lengau lengau force-pushed the work/2001/CRAFT-3707/use-uv branch 28 times, most recently from a384980 to d1522af Compare December 9, 2024 23:05
@lengau lengau requested a review from tigarmo December 9, 2024 23:50
@lengau lengau marked this pull request as ready for review December 9, 2024 23:50
@lengau lengau requested a review from tigarmo December 10, 2024 16:24
@tigarmo
Copy link
Contributor

tigarmo commented Dec 10, 2024

I'm keeping an eye on this and the changes seem fine - I'm just waiting for the changes that will be necessary to fix the spread tests breakage

mr-cal
mr-cal approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of changes here, but I don't see anything of concern. I've seen a starbase PR from you, so I assume you have been upstreaming changes where appropriate.

snap/hooks/configure Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
@lengau lengau force-pushed the work/2001/CRAFT-3707/use-uv branch 3 times, most recently from b9cf4fa to 569d95b Compare December 11, 2024 17:11
@lengau lengau force-pushed the work/2001/CRAFT-3707/use-uv branch from 569d95b to cab76c5 Compare December 11, 2024 17:23
@lengau lengau enabled auto-merge December 11, 2024 17:25
@lengau lengau disabled auto-merge December 11, 2024 17:25
@lengau lengau merged commit 0215ac0 into main Dec 11, 2024
18 of 19 checks passed
@lengau lengau deleted the work/2001/CRAFT-3707/use-uv branch December 11, 2024 17:25
@lengau lengau linked an issue Dec 17, 2024 that may be closed by this pull request
Migrate testing jobs to starflow #2001
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@tigarmo tigarmo tigarmo approved these changes

Assignees
No one assigned
Labels
rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate testing jobs to starflow
3 participants
@lengau @tigarmo @mr-cal