Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support juju 3.4 #25

Merged

Conversation

rgildein
Copy link
Contributor

Add support for Juju 3.4, small clean up in Makefile and func test bundles (using base.yaml) and mayor change is to switch to run these test on LXD, so official GitHub runner can be used instead of self-hosted.

Add workflow concurrency to avoid running multiple workflows on a single PR. Like this if new commit arrived the previous run will be canceled by new run.

Switch to Juju 3.4 controller, add concurrency to GH workflow, user
master branch of zaza and simply repo sanitazation.
Clean up func test bundles and add constraints
virt-type=virtual-machine, so test can be run on LXD.
@rgildein rgildein added the enhancement New feature or request label Apr 22, 2024
@rgildein rgildein self-assigned this Apr 22, 2024
@rgildein rgildein requested a review from a team as a code owner April 22, 2024 18:04
@rgildein rgildein requested review from Pjack, aieri and jneo8 April 22, 2024 18:04
Copy link

@aieri aieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised functional tests run on LXDs, I thought we needed a kernel

@rgildein
Copy link
Contributor Author

I'm surprised functional tests run on LXDs, I thought we needed a kernel

I'm using LXD VM, check this line.

Copy link
Contributor

@dashmage dashmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice change to move the tests to run on an LXD VM via the constraints :)

@rgildein rgildein merged commit b6bafcc into canonical:master Apr 23, 2024
3 checks passed
@rgildein rgildein deleted the release/BSENG-2370/support-juju-3.4 branch April 23, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants