Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure storage native support #30

Closed
wants to merge 177 commits into from
Closed

Add Azure storage native support #30

wants to merge 177 commits into from
+6 −0

Conversation

ashugauttam225
Copy link
Contributor

@ashugauttam225 ashugauttam225 commented May 26, 2024 •
edited by samuelallan72
Loading

i have added the functionality for native support for Azure storage, which makes it available to store backups in Azure in a Juju-managed way.
Please review and do comment and i will make the necessary changes accordingly.
I will add the unit test later.

Fixes: #29

@ashugauttam225 ashugauttam225 requested a review from a team as a code owner May 26, 2024 19:40
jneo8
jneo8 requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@jneo8 jneo8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
Please include unit tests in the PR, thanks.

src/config.yaml Outdated Show resolved Hide resolved
src/lib/lib_duplicity.py Outdated Show resolved Hide resolved
src/reactive/duplicity.py Outdated Show resolved Hide resolved
jneo8
jneo8 requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please include unit tests in the PR.

src/lib/lib_duplicity.py Outdated Show resolved Hide resolved
src/lib/lib_duplicity.py Outdated Show resolved Hide resolved
src/reactive/duplicity.py Outdated Show resolved Hide resolved
src/reactive/duplicity.py Outdated Show resolved Hide resolved
samuelallan72
samuelallan72 requested changes May 29, 2024
View reviewed changes
src/config.yaml Show resolved Hide resolved
src/lib/lib_duplicity.py Outdated Show resolved Hide resolved
jneo8
jneo8 requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leave a message to confirm the scope of this PR.
And do we want to make juju2/3 compatible in this PR? Or you will provide another PR to fix it?

src/reactive/duplicity.py Outdated Show resolved Hide resolved
@jneo8
Copy link
Contributor

jneo8 commented Jun 27, 2024

Hi @ashugauttam225 , are you still work on this one?

jneo8
jneo8 previously approved these changes Jul 31, 2024
View reviewed changes
chanchiwai-ray
chanchiwai-ray previously approved these changes Jul 31, 2024
View reviewed changes
@ashugauttam225 ashugauttam225 dismissed stale reviews from chanchiwai-ray and jneo8 via e1b3d43 July 31, 2024 12:47
@samuelallan72 samuelallan72 changed the title Added Azure storage native support, for issue #29 Added Azure storage native support Jul 31, 2024
@samuelallan72 samuelallan72 changed the title Added Azure storage native support Add Azure storage native support Jul 31, 2024
dashmage and others added 28 commits August 12, 2024 02:16
@dashmage @ashugauttam225
Refactor code
fcaac43 
- Add ubuntu release check
- Use single variable for private key checking and conversion
- Remove extra var in unit test
@dashmage @ashugauttam225
Fix for BSENG-916
07646b2
@dashmage @ashugauttam225
Revert previous commit to apply fix separately
f197947
@dashmage @ashugauttam225
Fix lint error
2734ce7
@dashmage @ashugauttam225
Fix unit test
3c92a00 
- Parametrize and mock ubuntu release
@dashmage @ashugauttam225
Improve code readability + add comment for series check
82cefb4
@dashmage @ashugauttam225
Remove ssh backend from charm config
1847d6e
@rgildein @ashugauttam225
fix linting issue with unit test fix
e84ea6c 
There was linting issue and also wrong unit tests.
@rgildein @ashugauttam225
Add pkg-config, disable system packages
810c41f 
This patch provide fix for installation fabric on bionic series.
Adding pkg-config according documentation + disable system Python
packages.

fixes: #1968367
@chanchiwai-ray @ashugauttam225
Included documentation page in metadata.yaml
d8868cc
@chanchiwai-ray @ashugauttam225
Added LICENSE
c6b0f42
@jneo8 @ashugauttam225
build(juju-3.1): Drop bionic and change zaza dependency to branch lib…
0e488c4 
…juju-3.1
@jneo8 @ashugauttam225
ci: Enable github workflow (canonical#20)
0c9106f
@dashmage @ashugauttam225
Move README file to repo root (canonical#21)
8998a00
@zxhdaze @ashugauttam225
BSENG-2324 fix linting (canonical#25)
71c2360
@rgildein @ashugauttam225
change from workflow_call to workflow_dispatch (canonical#24)
bd48796 
Like this, we can automatically trigger this workflow by our weekly tests.
@rgildein @ashugauttam225
Support juju 3.4 (canonical#26)
1e69b3c
@rgildein @aieri @ashugauttam225
Add new release and promote workflow (canonical#27)
0076734 
* Add new release and promote workflow

Using official actions directly.

* apply suggestions

* using officail action to setup LXD

* Update .github/workflows/release.yaml

Co-authored-by: Andrea Ieri <[email protected]>

---------

Co-authored-by: Andrea Ieri <[email protected]>
@ashugauttam225
Added Azure storage native support
4ed31cf
@ashugauttam225
Added Azure storage native support
f96eee1
@ashugauttam225
added azure as backend for storage
ac374fd
@ashugauttam225
added azure as backend for storage
21c6eb1
@ashugauttam225
added azure as backend for storage
95efd1a
@ashugauttam225
added azure as backend for storage
1035242
@ashugauttam225
added azure as backend for storage
7bd2c15
@ashugauttam225
added azure as backend for storage
08140e7
@ashugauttam225
added azure as backend for storage
45f2f31
@ashugauttam225
added azure as backend for storage
fddb989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudeephb sudeephb sudeephb left review comments

@chanchiwai-ray chanchiwai-ray chanchiwai-ray approved these changes

@samuelallan72 samuelallan72 samuelallan72 approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@gabrielcocenza gabrielcocenza Awaiting requested review from gabrielcocenza gabrielcocenza is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8

@dparv dparv Awaiting requested review from dparv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Azure storage native support