Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new release and promote workflow #27

Merged
merged 4 commits into from
May 6, 2024
Merged

Add new release and promote workflow #27

merged 4 commits into from
May 6, 2024
+44 −14

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented May 3, 2024

Using official actions directly.

@rgildein
Add new release and promote workflow
995fa79 
Using official actions directly.
@rgildein rgildein added the enhancement New feature or request label May 3, 2024
@rgildein rgildein self-assigned this May 3, 2024
@rgildein rgildein requested a review from a team as a code owner May 3, 2024 12:52
aieri
aieri requested changes May 6, 2024
View reviewed changes
.github/workflows/release.yaml Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
jneo8
jneo8 previously approved these changes May 6, 2024
View reviewed changes
.github/workflows/release.yaml Outdated Show resolved Hide resolved
chanchiwai-ray
chanchiwai-ray requested changes May 6, 2024
View reviewed changes
Copy link
Contributor

@chanchiwai-ray chanchiwai-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't have too much idea about destructive mode, and the implication of that now. One small nit is to provide some examples in the promote.yaml in the choice of inputs

.github/workflows/promote.yaml Outdated Show resolved Hide resolved
@rgildein rgildein requested review from aieri, chanchiwai-ray and jneo8 May 6, 2024 11:19
chanchiwai-ray
chanchiwai-ray previously approved these changes May 6, 2024
View reviewed changes
rgildein added a commit to rgildein/charm-duplicity that referenced this pull request May 6, 2024
@rgildein
Test of CI for canonical#27
5ee88f7
aieri
aieri reviewed May 6, 2024
View reviewed changes
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/promote.yaml Show resolved Hide resolved
@rgildein rgildein merged commit a0ea934 into canonical:main May 6, 2024
3 checks passed
@rgildein rgildein deleted the chore/BSENG-2428/apply-new-release branch May 6, 2024 13:41
@rgildein rgildein mentioned this pull request May 6, 2024
Merged
This was referenced May 7, 2024
Merged
Merged
Merged
ashugauttam225 pushed a commit to ashugauttam225/charm-duplicity that referenced this pull request Aug 11, 2024
@rgildein @aieri @ashugauttam225
Add new release and promote workflow (canonical#27)
0076734 
* Add new release and promote workflow

Using official actions directly.

* apply suggestions

* using officail action to setup LXD

* Update .github/workflows/release.yaml

Co-authored-by: Andrea Ieri <[email protected]>

---------

Co-authored-by: Andrea Ieri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanchiwai-ray chanchiwai-ray chanchiwai-ray approved these changes

@jneo8 jneo8 jneo8 approved these changes

@aieri aieri aieri approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@samuelallan72 samuelallan72 Awaiting requested review from samuelallan72 samuelallan72 is a code owner automatically assigned from canonical/soleng-reviewers

@gabrielcocenza gabrielcocenza Awaiting requested review from gabrielcocenza gabrielcocenza is a code owner automatically assigned from canonical/soleng-reviewers

@sudeephb sudeephb Awaiting requested review from sudeephb

Assignees

@rgildein rgildein

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rgildein @aieri @jneo8 @sudeephb @chanchiwai-ray