Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support juju 3.4 #26

Merged

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented Apr 11, 2024

Using master branch for zaza with TEST_JUJU3=1 1 and dropping
bootstack-actions for func in CI to be able to use specific lxd
channel.

Changing to use of Juju 3.4 controller for testing instead of Juju 3.1, using TEST_JUJU3=1 1 for zaza to install proper libjuju version.

Simply sanitation of project and add workflow concurrency to avoid running multiple workflows on a single PR. Like this if new commit arrived the previous run will be canceled by new run.

blocked until #655 is not merged


@rgildein rgildein added the enhancement New feature or request label Apr 11, 2024
@rgildein rgildein self-assigned this Apr 11, 2024
@rgildein rgildein requested a review from a team as a code owner April 11, 2024 13:51
@rgildein rgildein requested review from Pjack, aieri, agileshaw and jneo8 April 11, 2024 13:51
Using master branch for zaza with TEST_JUJU3=1 [1] and dropping
bootstack-actions for func in CI to be able to use specific lxd
channel.

---
[1]:
openstack-charmers/zaza@af7eea9
@rgildein rgildein force-pushed the release/BSENG-2332/support-juju-3.4 branch from 19bd8e1 to d716e62 Compare April 11, 2024 13:56
@rgildein rgildein force-pushed the release/BSENG-2332/support-juju-3.4 branch 2 times, most recently from c70fde3 to f8686b3 Compare April 11, 2024 14:43
@rgildein rgildein force-pushed the release/BSENG-2332/support-juju-3.4 branch from f8686b3 to 1c12b2f Compare April 11, 2024 15:34
@Pjack Pjack self-requested a review April 12, 2024 10:02
.github/workflows/check.yaml Outdated Show resolved Hide resolved
@rgildein rgildein marked this pull request as draft April 15, 2024 18:16
@rgildein rgildein force-pushed the release/BSENG-2332/support-juju-3.4 branch 2 times, most recently from e977baf to dd52899 Compare April 15, 2024 18:23
@rgildein
Copy link
Contributor Author

Converted to draft, to test zaza version.
Using my version zaza to test fix for support 2.9 and 3.4 by zaza. Please do not merge.

@rgildein rgildein force-pushed the release/BSENG-2332/support-juju-3.4 branch from dd52899 to a17ee2e Compare April 15, 2024 18:28
Fix requirements for install hook not to failed, drop series from
metadata.yaml.
@rgildein rgildein force-pushed the release/BSENG-2332/support-juju-3.4 branch from e833b26 to 53640c0 Compare April 15, 2024 20:43
@rgildein rgildein changed the title Release/bseng 2332/support juju 3.4 Support juju 3.4 Apr 16, 2024
@rgildein rgildein marked this pull request as ready for review April 16, 2024 21:14
rgildein and others added 2 commits April 18, 2024 18:34
The 60-cloudimg-settings.conf exist on new LXD with
"PasswordAuthentication no" so we need to define our own config file.
@rgildein rgildein force-pushed the release/BSENG-2332/support-juju-3.4 branch from c6d0e7c to c7463d1 Compare April 19, 2024 14:32
@rgildein rgildein requested review from Pjack and aieri April 23, 2024 16:33
jneo8
jneo8 previously requested changes Apr 24, 2024
Copy link
Contributor

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check why is the CI fail.

@rgildein
Copy link
Contributor Author

Please check why is the CI fail.

It's due PasswordAuthentication no, which comes with new image configuration in 60-cloudimg-settings.conf, and I tried to fix it with 'echo "PasswordAuthentication yes" > 01-test-settings.conf' instead of sed -i 's/PasswordAuthentication no/PasswordAuthentication yes/' /etc/ssh/sshd_config.
It was working on my local LXD fine, I'll test it again.

@rgildein
Copy link
Contributor Author

I did not use full path, so that was a problem.

@rgildein rgildein requested a review from jneo8 April 24, 2024 13:51
@Pjack Pjack removed the request for review from agileshaw April 24, 2024 14:35
@rgildein rgildein dismissed jneo8’s stale review April 25, 2024 18:31

All comments have been resolved.

@rgildein rgildein merged commit 2c7c582 into canonical:master Apr 25, 2024
3 checks passed
@rgildein rgildein deleted the release/BSENG-2332/support-juju-3.4 branch April 26, 2024 11:35
ashugauttam225 pushed a commit to ashugauttam225/charm-duplicity that referenced this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants