Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-17111 - Implement new data/streaming page and form #1470

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pedoch
Copy link
Contributor

@pedoch pedoch commented Dec 18, 2024

Done

Implement new page: /data/streaming

QA

Issue / Card

@webteam-app
Copy link

@mattea-turic
Copy link
Collaborator

mattea-turic commented Dec 19, 2024

Thanks @pedoch ! A couple of comments:

For the hero section:

  • I noticed that the image is a little too light at the top (blends with bg), so I've added an updated asset here

For the "Streaming use cases" section:

  • Could you wrap the 50/50 subsection (text + video) in a shallow pls?
  • And use a muted hr above the grid of images

For the "Canonical solutions for data streaming" section:

  • On mobile, there's spacing lacking between the two pricing cards

For the "resources" section:

  • The hrs that don't span full-width should be muted

For the footer:

  • I think you've mistakenly duplicated the trademark text

@pedoch pedoch force-pushed the WD-17111-dev-webpage-webpage-data-streaming branch from 9d29ca6 to f672f52 Compare January 6, 2025 09:21
@pedoch
Copy link
Contributor Author

pedoch commented Jan 6, 2025

Thanks for the review @mattea-turic. I've made the changes that were requested.

A couple of things to note:

  • While I added space on the pricing cards, I checked for other examples where this was used, and the cards on other pages don't have a space between them on mobile screens. So, this is kind of a "custom solution" for this page.
  • The trademark texts are actually different; they are very similar but refer to different products. This is how it's stated in the copy. They could be merged, but that must be changed on the copy doc.

@mattea-turic
Copy link
Collaborator

Hey @pedoch , the link for the page doesn't seem to be working (https://canonical-com-1470.demos.haus/data/streaming) for me

@pedoch
Copy link
Contributor Author

pedoch commented Jan 6, 2025

@mattea-turic looks like demos aren't coming up. I'll let you know as soon as it's up.

@pedoch
Copy link
Contributor Author

pedoch commented Jan 7, 2025

@mattea-turic the demo is up now

@mattea-turic
Copy link
Collaborator

Thanks @pedoch , LGTM! I'll +1 for design

@eliman11
Copy link
Collaborator

eliman11 commented Jan 7, 2025

Thanks @pedoch looks great! Nothing missing from UX once we have the Marketo ID and whitepaper link you've pinged about already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants