Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all flask search references in favour of RTD #355

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Remove all flask search references in favour of RTD #355

merged 1 commit into from
Oct 8, 2024

Conversation

aaryanporwal
Copy link
Contributor

@aaryanporwal aaryanporwal commented Sep 30, 2024 •
edited
Loading

Done

  • Upgraded webteam.flask-base version
  • Removed webteam.search and webteam.discourse module since we moved to read the docs in Add page redirects to RTD #350
  • Removed all unused markup, styles and python functions for search.

QA

Issue / Card

Fixes WD-15028

@webteam-app
Copy link

Demo

Jenkins

demos.haus

edlerd
edlerd reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@edlerd edlerd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but the demo build is failing, so can't QA yet.

@aaryanporwal aaryanporwal force-pushed the remove-flask-search branch 2 times, most recently from 22fbe5e to 180ac30 Compare October 4, 2024 13:24
@aaryanporwal aaryanporwal requested a review from edlerd October 7, 2024 17:46
@aaryanporwal
Copy link
Contributor Author

Fixed the build, set a new secret-key in demo k8s cluster. Please check the demo build.

edlerd
edlerd approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx for cleaning this up and also for the demo fix 👍

@aaryanporwal aaryanporwal merged commit fd353d4 into canonical:main Oct 8, 2024
6 checks passed
@aaryanporwal aaryanporwal deleted the remove-flask-search branch October 8, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaryanporwal @webteam-app @edlerd