Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WD-12159] chore: Updated yarn.lock dependencies #344

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

Kxiru
Copy link
Contributor

@Kxiru Kxiru commented Jun 24, 2024

Done

  • Used ncu -u command to update dependencies
  • Maintained the correct version of "intl-tel-input":"17.0.21".

QA

  • Check out this feature branch
  • Review yarn.lock file

Issue / Card

Fixes out of date dependencies

Screenshots

N/A

@Kxiru Kxiru requested a review from edlerd June 24, 2024 10:10
@Kxiru Kxiru self-assigned this Jun 24, 2024
@webteam-app
Copy link

Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo build is failing because it can't find esbuild. I assume some of the dependencies can't be moved to dev dependencies. Can you have a look and ensure the build passes?

@Kxiru
Copy link
Contributor Author

Kxiru commented Jun 24, 2024

The demo build is failing because it can't find esbuild. I assume some of the dependencies can't be moved to dev dependencies. Can you have a look and ensure the build passes?

Hey David,
How do you know that esbuild cannot be found? When I read the error logs, it implies it cannot find build-css and build-js. Is there another place that I should be looking?

@edlerd
Copy link
Contributor

edlerd commented Jun 24, 2024

The demo build is failing because it can't find esbuild. I assume some of the dependencies can't be moved to dev dependencies. Can you have a look and ensure the build passes?

Hey David, How do you know that esbuild cannot be found? When I read the error logs, it implies it cannot find build-css and build-js. Is there another place that I should be looking?

From the jenkins log:

#26 0.520 Error: Cannot find module 'esbuild'
#26 0.520 Require stack:
#26 0.520 - /srv/build.js
#26 0.520     at Module._resolveFilename (node:internal/modules/cjs/loader:1145:15)
#26 0.520     at Module._load (node:internal/modules/cjs/loader:986:27)
#26 0.520     at Module.require (node:internal/modules/cjs/loader:1233:19)
#26 0.520     at require (node:internal/modules/helpers:179:18)
#26 0.520     at Object.<anonymous> (/srv/build.js:1:15)
#26 0.520     at Module._compile (node:internal/modules/cjs/loader:1358:14)
#26 0.520     at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
#26 0.520     at Module.load (node:internal/modules/cjs/loader:1208:32)
#26 0.520     at Module._load (node:internal/modules/cjs/loader:1024:12)
#26 0.520     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12) {
#26 0.520   code: 'MODULE_NOT_FOUND',
#26 0.520   requireStack: [ '/srv/build.js' ]
#26 0.520 }

@Kxiru Kxiru force-pushed the update-dependencies branch 8 times, most recently from 583e196 to da819aa Compare June 24, 2024 15:24
@Kxiru Kxiru force-pushed the update-dependencies branch from da819aa to 7ca4d36 Compare June 24, 2024 15:26
@Kxiru
Copy link
Contributor Author

Kxiru commented Jun 24, 2024

@edlerd , After testing, I have realised that tests fail in demo/jenkins because the build scripts rely on all of the dependencies that you have asked me to move to DevDependencies (I ran them one by one to double check).
That being said, all of the version have been updated.

@Kxiru Kxiru requested a review from edlerd June 24, 2024 16:01
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wasn't aware those dependencies may not be dev dependencies for the build to pass. Thanks for the updates.

@Kxiru Kxiru merged commit a30a8bc into canonical:main Jun 24, 2024
6 checks passed
@Kxiru Kxiru deleted the update-dependencies branch June 24, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants