-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WD-12159] chore: Updated yarn.lock dependencies #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The demo build is failing because it can't find esbuild
. I assume some of the dependencies can't be moved to dev dependencies. Can you have a look and ensure the build passes?
Hey David, |
From the jenkins log:
|
583e196
to
da819aa
Compare
Signed-off-by: Nkeiruka <[email protected]>
da819aa
to
7ca4d36
Compare
@edlerd , After testing, I have realised that tests fail in demo/jenkins because the build scripts rely on all of the dependencies that you have asked me to move to DevDependencies (I ran them one by one to double check). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I wasn't aware those dependencies may not be dev dependencies for the build to pass. Thanks for the updates.
Done
QA
Issue / Card
Fixes out of date dependencies
Screenshots
N/A