add a parameter to YT video URL link to prevent unnecessary suggestions #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
edlerd
reviewed
May 14, 2024
There was a problem hiding this comment.
the demo link looks broken, the first part of the home page has a grey background which doesn't play well with the image on the right side:
This is different to https://anbox-cloud.io/ where we have a white background for the first strip on the homepage.
Hmm I can't pin point what must be causing that disparity. |
|
I just rebased, and I think it works. Can you take a look again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Added a rel=0 parameter to YouTube URL link to prevent videos from other channels to show up in suggestions after the video reaches the end. The solution comes from this SO thread.
Similar to: canonical/ubuntu.com#13862
QA
Check out the demos
Play the YouTube embedded video on the homepage till the end
Check all the suggestion videos that pop-up and check if all of them come from Canonical YT channel.
Issue / Card
Fixes #
Screenshots
[if relevant, include a screenshot]