Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation on smaller screens #329

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Fix navigation on smaller screens #329

merged 2 commits into from
Feb 2, 2024

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Jan 24, 2024

Done

Fixes top navigation on medium screens (tablets) by properly adjusting breakpoint value, passing it to global nav, and adding medium screen column values.

Before:

image

After

image

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8043/
  • Run through the following QA steps
  • Check if top navigation displays correctly on various screen sizes (from mobile, through tablet, up to desktop)

@webteam-app
Copy link

Demo starting at https://anbox-cloud-io-329.demos.haus

Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one tiny nitpick. Feel free to merge as is.

static/sass/_settings.scss Outdated Show resolved Hide resolved
@edlerd edlerd merged commit 2a44b61 into main Feb 2, 2024
7 checks passed
@edlerd edlerd deleted the nav-fix branch February 2, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants