feat: Remove deprecated syspurpose top-level commands

[Glutexo]

Removes addons, role, service-level, and usage commands. These are deprecated as top-level commands as they’ve been moved to the syspurpose command as sub-commands.

CCT-402

[jirihnidek]

You have to at least remove addons.py and test_addons.py.

[Glutexo]

@jirihnidek The AddonsCommand class in addons.py is imported as a subcommand in syspurpose.py.

[Glutexo]

test_addons.py needs to be kept too. The command is still there, just not as a first-class command, but rather as a syspurpose command’s subcommand. The test doesn’t verify the actual CLI syntax, but rather the already invoked command.

[Glutexo]

Or maybe not. 🤔 This line looks suspicious:

subscription-manager/test/cli_command/test_addons.py

Line 32 in dd68e24

argv_patcher = patch.object(sys, "argv", ["subscription-manager", "addons"])

But the tests pass even though I removed the command from managercli.

[Glutexo]

It works regardless of the argv value… 🤷🏻‍♂️

[Glutexo]

I think I found all the places where the addons command needs to be removed. I‘ll do the same for the other commands moved under the syspurpose subcommand.

@jirihnidek Do you think it’s ok this way? Didn’t I forget anything?

[Glutexo]

Interesting. In test_role.py, the setUp method doesn’t contain the argv patch present in test_addons.py. test_addons.py however works without the path just fine…

[ptoscano]

This seems generally good; please rebase it to fix the conflicts.

Also, if this is ready to be reviewed and merged, please un-draft/un-wip it, thanks.

[ptoscano]

This will break the cockpit tests, which currently still use the old commands.
I just created a PR to change those: candlepin/subscription-manager-cockpit#69

This PR will need to wait until that is merged.

(also, is it still "wip"?)

[Glutexo]

Fine-tuned the pull request, so it can be reviewed and merged:

[ptoscano]

LGTM, thanks!