feat!: use vrs 2.0-alpha models in /normalize #140

korikuzma · 2023-09-12T21:41:01Z

Close #135 . Going to wait to open until I confirm everything works in metakb. But would still like your review @jsstevenson now

Notes:

Update to pydantic v2
Remove ga4gh.vrsatile.pydantic depdency and use ga4gh.vrs for core/vrs 2.0-alpha models
Set response_model_exclude_none=True in FastAPI response

disease/query.py

korikuzma added 3 commits September 10, 2023 11:30

build: update to pydantic v2 and remove ga4gh.vrsatile.pydantic

d55a134

use core_models.Disease

bb218fe

new line for pipfile

9f59e1e

korikuzma added enhancement New feature or request priority:high High priority labels Sep 12, 2023

korikuzma requested a review from jsstevenson September 12, 2023 21:41

korikuzma self-assigned this Sep 12, 2023

korikuzma added 2 commits September 12, 2023 18:43

rm vod

6c7cc58

use lower case for system

9f9e7b0

korikuzma commented Sep 13, 2023

View reviewed changes

disease/query.py Outdated Show resolved Hide resolved

korikuzma mentioned this pull request Sep 13, 2023

feat!: use vrs 2.0-alpha models in /normalize cancervariants/therapy-normalization#364

Merged

korikuzma added 2 commits September 13, 2023 10:47

update handling ids

35ae54a

fix adding merged meta

a7e21eb

korikuzma force-pushed the issue-135 branch from 65f4daf to a7e21eb Compare September 13, 2023 17:04

korikuzma added 2 commits September 27, 2023 09:40

build: update ga4gh.vrs

11bbc56

revert source priority (do in new issue)

894d319

korikuzma marked this pull request as ready for review September 27, 2023 13:49

jsstevenson approved these changes Sep 27, 2023

View reviewed changes

korikuzma merged commit 37b56dd into staging Sep 27, 2023
24 checks passed

korikuzma deleted the issue-135 branch September 27, 2023 17:05

Provide feedback