Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor images patterns #91

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

delisma
Copy link
Contributor

@delisma delisma commented Jul 31, 2022


name: Image patterns
about: This a pull request to "componentize" patterns in Jekyll
title: chore: Refactor images patterns
labels: enhancement
assignees: @delisma

What does this MR do?

Create gc-complex-img and gc-simple-img pattern
Update posts to adopt new image patterns

General checklist

  • Documentation created/updated
  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Conforms to the style guides

Related

#61

@delisma delisma requested a review from arianna-merritt July 31, 2022 16:55
@delisma
Copy link
Contributor Author

delisma commented Jul 31, 2022

@arianna-merritt The new pattern is supposed to simplify the use of complex images. I was wondering if attribute like file, caption, summary and content are enough self-explanatory compare to src, caption, summary and details.

{% include components/gc-complex-img.html
	 alt="A long description can be found after the image."
	 file=""
	 caption=""
	 summary=""
	 content=""
%}

or

{% include components/gc-complex-img.html
	 alt="A long description can be found after the image."
	 src=""
	 caption=""
	 summary=""
	 details=""
%}

@delisma delisma self-assigned this Jul 31, 2022
@delisma delisma added the enhancement New feature or request label Jul 31, 2022
@delisma delisma linked an issue Jul 31, 2022 that may be closed by this pull request
Create gc-complex-img and gc-simple-img pattern
Update posts to adopt new image patterns
@delisma delisma force-pushed the hotfix/fix-images-retro branch from 5033bc0 to 5cac55b Compare August 2, 2022 12:25
@arianna-merritt arianna-merritt merged commit e45afd4 into canada-ca:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants