Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop worker if channel is closed #526

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dimastbk
Copy link
Collaborator

@dimastbk dimastbk commented Nov 2, 2024

Description of PR...

Changes

  • Item 1
  • Item 2

API Updates

New Features (required)

This section should include details regarding new features added to the library.
This should include both open and private APIs. If including both, create two
sub headers underneath this one to label updates accordingly.

Deprecations (required)

All deprecations should be listed here in order to ensure the reviewer understands
which sections of the codebase will affect contributors and users of the library.

Enhancements (optional)

The enhancements section should include code updates that were included with this
pull request. This sections should detail refactoring that might have affected
other parts of the library.

Checklist

  • Unit tests
  • Documentation

References

(optional)

Include important links regarding the implementation of this PR.
This usually includes and RFC or an aggregation of issues and/or individual conversations
that helped put this solution together. This helps ensure there is a good aggregation
of resources regarding the implementation.

@coveralls
Copy link

coveralls commented Nov 2, 2024

Pull Request Test Coverage Report for Build 11664521603

Details

  • 15 of 16 (93.75%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.4%) to 98.3%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyzeebe/worker/worker.py 6 7 85.71%
Totals Coverage Status
Change from base Build 11659466005: 1.4%
Covered Lines: 1041
Relevant Lines: 1059

💛 - Coveralls

@dimastbk dimastbk changed the title fix: set adapter.connected = False on channel closing feat: stop worker if channel is closed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants