Set up dataset page #9
Conversation
There was a problem hiding this comment.
Thanks for setting up the dataset details page 🚀 !
I think for the initial setup it looks good. Later on we can exchange the components and adapt it to the MEL style.
I couldn't find a dataset that has API, so I did not test this part.
Maybe you also want to add some e2e tests? Just to check if the main components are present.
| </div> | ||
| <!-- TODO: create corresponding UI component --> | ||
| <div> | ||
| <div>mel.dataset.informations</div> |
There was a problem hiding this comment.
Did you add this key in the translation file already? I could not find it, but it still seems to work..?
There was a problem hiding this comment.
Ah, good catch, I even forgot to add the translate attribute. Strangely this does not get extracted even after adding the attribute 🤔
| </div> | ||
| </div> | ||
| } } | ||
| <div |
There was a problem hiding this comment.
I think this should be the @else case?
There was a problem hiding this comment.
Good point, I've updated this
| > | ||
| <div class="bg-primary-opacity-10 py-8"> | ||
| <div class="flex flex-col px-4 gap-8 container-lg lg:mx-auto"> | ||
| <div class="flex flex-wrap justify-between sm:mb-2 ng-star-inserted"> |
There was a problem hiding this comment.
What does the ng-star-inserted do? Isn't that something internally from angular?
There was a problem hiding this comment.
Not sure, this comes from gn-ui for now but will surely still change
allowing to display relevant information from mdview.facade
based on gn-ui's record-apis and underlying components
which was broken due to StoreRouterConnectingModule.forRoot()
somehow mel.dataset.informations is not extracted and keys already translated in gn-ui are extracted
|
Thanks for the review @Angi-Kinas. I haven't added any e2e tests here yet, as the goal was just to make the information accessible to the UI parts. I think we should add the e2e tests when we implement the UI, as the DOM and tag names will still change significantly. What do you think? There is still an issue open with the i18n extraction not working properly in this PR, however. |
|
The i18n translation issue has been solved by updating to |
The goal of this PR is to set a base for the dataset page by
MdViewFacadeTo-dos for upcoming UI work are marked in the template.