-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up search states and base components #5
Conversation
to list last created records and favorites
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some residual component files, you should use the nx cli to create the structure and the components.
For the state search it looks good 👍
For the file structure, it's ok, you could have put some UI components in the dedicated page folder but's it's kifkif
Think of embracing ng17 nex features though 😏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those files are not used, how do you generate your components ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I oversaw this one after creating the extends
...pp/common/results-list-item/results-card-last-created/results-card-last-created.component.ts
Outdated
Show resolved
Hide resolved
...tahub/src/app/common/results-list/results-list-carousel/results-list-carousel.component.html
Outdated
Show resolved
Hide resolved
apps/datahub/src/app/common/results-list/results-list.component.spec.ts
Outdated
Show resolved
Hide resolved
Thanks for your feedback @fgravin !
Correct, I didn't pay attention to this, should be cleaner now.
Yep, I chose to put all
Noted 👍 |
removing @ngx-translate/http-loader overriding gn-ui version for @ngx-translate/core
This PR intends setting up a base that allows to create the various metadata record lists in different layouts.
mainSearch
state for the results grid, bound to the routerheaderHome
state via a directive for the last created record, displayed in the home headerheaderSearch
state via a directive for the favorite records, displayed in the search headermel-datahub-results-list-carousel
mel-datahub-results-list-grid
mel-datahub-results-card-favorite
mel-datahub-results-card-last-created
mel-datahub-results-card-search