Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up search states and base components #5

Merged
merged 15 commits into from
Jan 19, 2024
Merged

Set up search states and base components #5

merged 15 commits into from
Jan 19, 2024

Conversation

tkohr
Copy link
Member

@tkohr tkohr commented Jan 17, 2024

This PR intends setting up a base that allows to create the various metadata record lists in different layouts.

  • it introduces three search states
    • a mainSearch state for the results grid, bound to the router
    • a headerHome state via a directive for the last created record, displayed in the home header
    • a headerSearch state via a directive for the favorite records, displayed in the search header
  • it adds two different results-list components based on a common base component (allowing to implement different layouts)
    • mel-datahub-results-list-carousel
    • mel-datahub-results-list-grid
  • it adds three different results-list-item components based on a common base component (allowing to implement different layouts)
    • mel-datahub-results-card-favorite
    • mel-datahub-results-card-last-created
    • mel-datahub-results-card-search

Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some residual component files, you should use the nx cli to create the structure and the components.

For the state search it looks good 👍

For the file structure, it's ok, you could have put some UI components in the dedicated page folder but's it's kifkif

Think of embracing ng17 nex features though 😏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those files are not used, how do you generate your components ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I oversaw this one after creating the extends

@tkohr tkohr marked this pull request as ready for review January 18, 2024 15:17
@tkohr
Copy link
Member Author

tkohr commented Jan 18, 2024

Thanks for your feedback @fgravin !

There are some residual component files, you should use the nx cli to create the structure and the components.

Correct, I didn't pay attention to this, should be cleaner now.

For the file structure, it's ok, you could have put some UI components in the dedicated page folder but's it's kifkif

Yep, I chose to put all results-list and results-list-item components in common as they will be easier to find and combine IMO.

Think of embracing ng17 nex features though 😏

Noted 👍

removing @ngx-translate/http-loader
overriding gn-ui version for @ngx-translate/core
@tkohr tkohr merged commit ed42810 into main Jan 19, 2024
5 checks passed
@tkohr tkohr deleted the search-states branch January 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants