fix(icons): use relative path

camptocamp · Feb 8, 2024 · 9b46e48 · 9b46e48
1 parent a155970
commit 9b46e48
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/apps/datahub-e2e/src/e2e/dataset.cy.ts b/apps/datahub-e2e/src/e2e/dataset.cy.ts
@@ -46,7 +46,7 @@ describe('datasets', () => {
       cy.get('mel-datahub-text-expand')
         .find('mel-datahub-button-primary')
         .find('img')
-        .should('have.attr', 'src', '/assets/icons/arrow.svg')
+        .should('have.attr', 'src', 'assets/icons/arrow.svg')
       cy.get('mel-datahub-text-expand')
         .find('.bg-gradient-to-b')
         .should('have.css', 'max-height', '72px')
@@ -63,7 +63,7 @@ describe('datasets', () => {
       cy.get('mel-datahub-text-expand')
         .find('mel-datahub-button-primary')
         .find('img')
-        .should('have.attr', 'src', '/assets/icons/arrow-up.svg')
+        .should('have.attr', 'src', 'assets/icons/arrow-up.svg')
       cy.get('mel-datahub-text-expand')
         .find('.bg-gradient-to-b')
         .should('not.exist')
@@ -83,11 +83,11 @@ describe('datasets', () => {
       cy.get('mel-datahub-button-primary').eq(0).as('favoriteButton')
       cy.get('@favoriteButton')
         .find('img')
-        .should('have.attr', 'src', '/assets/icons/heart.svg')
+        .should('have.attr', 'src', 'assets/icons/heart.svg')
       cy.get('@favoriteButton').click()
       cy.get('@favoriteButton')
         .find('img')
-        .should('have.attr', 'src', '/assets/icons/heart-filled.svg')
+        .should('have.attr', 'src', 'assets/icons/heart-filled.svg')
     })
   })
 })
diff --git a/apps/datahub/src/app/common/button-primary/button-primary.component.ts b/apps/datahub/src/app/common/button-primary/button-primary.component.ts
@@ -10,7 +10,7 @@ export class ButtonPrimaryComponent {
   @Input() label: string
   @Input() set icon(fileName: string) {
     if (fileName) {
-      this.src = `/assets/icons/${fileName}.svg`
+      this.src = `assets/icons/${fileName}.svg`
       this.placeholder = fileName
     }
   }

diff --git a/apps/datahub/src/app/common/metadata-quality/mel-datahub-metadata-quality.component.html b/apps/datahub/src/app/common/metadata-quality/mel-datahub-metadata-quality.component.html
@@ -14,7 +14,7 @@
     <span class="text-[12px] font-bold">{{
       (qualityScore / 10).toFixed(1)
     }}</span>
-    <img [src]="'/assets/info.svg'" [alt]="'info'" />
+    <img [src]="'assets/icons/info.svg'" [alt]="'info'" />
   </div>
 
   <div

diff --git a/apps/datahub/src/assets/info.svg → apps/datahub/src/assets/icons/info.svg b/apps/datahub/src/assets/info.svg → apps/datahub/src/assets/icons/info.svg