Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookiekeyfile #19

Merged
merged 5 commits into from
Jun 5, 2017
Merged

Cookiekeyfile #19

merged 5 commits into from
Jun 5, 2017

Conversation

mgkuhn
Copy link
Contributor

@mgkuhn mgkuhn commented Jun 2, 2017

@jw35
Copy link

jw35 commented Jun 2, 2017

Two thoughts:

  • The documentation should probably mention that using file:/dev/urandom as the value of AACookieKey will have the side effect of triggering a round trip to Raven for all currently-authenticated users every time Apache is restarted/reloaded. While not a major issue, this will, for example, result in the loss of POST data (see Handle authentication triggered by HTTP POST better #20). Using file:/dev/urandom will also be problematic in many clustering configurations where requests may be handled by different copies of Apache at different times.

  • Using file:/dev/urandom with AAHeaderKey is pointless. The whole point of this directive is to establish a shared secret that allows other systems to verify who set particular headers. While very secure, a value that no one knows and that changes each time Apache is restarted isn't really useful here. The documentation should probably also mention this.

@jw35 jw35 merged commit 4f26af8 into cambridgeuniversity:master Jun 5, 2017
@mgkuhn
Copy link
Contributor Author

mgkuhn commented Jun 5, 2017

The mention of file:/dev/urandom is a bit experimental. I don't mind if you drop it from the documentation entirely if you don't find it useful, or potentially confusing. The file:/dev/urandom use case is the main reason for why I limited the number of bytes to be read to between 16 and 64, such that you can read from an infinitely-long character device, and are also protected from the pitfall that Linux /dev/random can deliver fewer bytes than requested (due to lack of estimated entropy).

@mgkuhn mgkuhn mentioned this pull request Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow AACookieKey/AAHeaderKey to read from a file (e.g. with file:// syntax)
2 participants