Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L4S/DSCP support to QoS Profile #384

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add L4S/DSCP support to QoS Profile #384

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2a101f
Add L4S/DSCP support to QoS Profile
benhepworth Dec 10, 2024
1c184aa
Add minimum and maximum value for dscp array
benhepworth Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions code/API_definitions/qos-profiles.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,20 @@ components:
minimum: 1
maximum: 10
example: 3
l4sQueueType:
type: string
enum:
- non-l4s-queue
- l4s-queue
- mixed-queue
description: Specifies the type of queue for L4S traffic management
differentiatedServicesCodepoint:
type: array
items:
type: integer
benhepworth marked this conversation as resolved.
Show resolved Hide resolved
minItems: 0
maxItems: 64
description: A list of unique DSCP values from 0-63
benhepworth marked this conversation as resolved.
Show resolved Hide resolved
Comment on lines +356 to +358
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
minItems: 0
maxItems: 64
description: A list of unique DSCP values from 0-63
minItems: 0
maxItems: 64
description: A list of unique DSCP values from 0-63, where each decimal value is mapped to the 6 bit DSCP value. For example `0` would be `000000` and `8` would be `001000` - where 0 and 8 would map to `CS0` and `CS1` respectively as defined in the [IANA DSCP Registry](https://www.iana.org/assignments/dscp-registry/dscp-registry.xhtml). This registry defines how [RFC 2474](https://www.rfc-editor.org/rfc/rfc2474) is to be used, while [RFC4594](https://datatracker.ietf.org/doc/html/rfc4594) defines recommended DSCPs to use for different application types. It is worth noting that some operating systems limit what DSCP values can be chosen. For example, Windows defines them for developers [this way](https://learn.microsoft.com/en-us/windows/win32/api/qos2/ne-qos2-qos_traffic_type). Therefore this allows multiple numeric DSCP values to be chosen in order to cover all operating systems and platforms.

required:
- name
- status
Expand Down
Loading