-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that duration out of range can't be reached for /extend #382
Merged
hdamker
merged 6 commits into
camaraproject:main
from
hdamker:377-how-to-reach-duration_out_of_range-for-sessionssessionidextend
Dec 7, 2024
Merged
Document that duration out of range can't be reached for /extend #382
hdamker
merged 6 commits into
camaraproject:main
from
hdamker:377-how-to-reach-duration_out_of_range-for-sessionssessionidextend
Dec 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added note to "DurationOutOfRangeForQoSProfile" that the error response QUALITY_ON_DEMAND.DURATION_OUT_OF_RANGE can't be reached and will be deleted within next version.
hdamker
requested review from
eric-murray,
RandyLevensalor and
jlurien
as code owners
December 1, 2024 21:41
hdamker
changed the title
377 how to reach duration out of range for sessionssessionidextend
Document that duration out of range can't be reached for /extend
Dec 1, 2024
eric-murray
reviewed
Dec 3, 2024
jlurien
reviewed
Dec 5, 2024
jlurien
previously approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor "formal" suggestion
Co-authored-by: Jose Luis Urien <[email protected]>
…of_range-for-sessionssessionidextend
eric-murray
reviewed
Dec 5, 2024
Co-authored-by: Eric Murray <[email protected]>
eric-murray
approved these changes
Dec 6, 2024
hdamker
deleted the
377-how-to-reach-duration_out_of_range-for-sessionssessionidextend
branch
December 7, 2024 14:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Documenting within the API definition of v0.11.x that the error response QUALITY_ON_DEMAND.DURATION_OUT_OF_RANGE will be deleted for the operation /extend within the next API version.
Which issue(s) this PR fixes:
Fixes #377
Special notes for reviewers:
Note: A new issue must be created for the final removal of the error response within the next release cycle.
Changelog input
Additional documentation
This section can be blank.