Add L4S/DSCP support to QoS Profile #384
Open
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhepworth
requested review from
hdamker,
eric-murray,
RandyLevensalor and
jlurien
as code owners
RandyLevensalor
requested changes
Dec 10, 2024
Co-authored-by: Randy Levensalor <[email protected]>
benhepworth
commented
Dec 11, 2024
There was a problem hiding this comment.
considering your changes, here is some additional verbiage @RandyLevensalor
Comment on lines
+356
to
+358
| minItems: 0 | ||
| maxItems: 64 | ||
| description: A list of unique DSCP values from 0-63 |
There was a problem hiding this comment.
Suggested change
| minItems: 0 | |
| maxItems: 64 | |
| description: A list of unique DSCP values from 0-63 | |
| minItems: 0 | |
| maxItems: 64 | |
| description: A list of unique DSCP values from 0-63, where each decimal value is mapped to the 6 bit DSCP value. For example `0` would be `000000` and `8` would be `001000` - where 0 and 8 would map to `CS0` and `CS1` respectively as defined in the [IANA DSCP Registry](https://www.iana.org/assignments/dscp-registry/dscp-registry.xhtml). This registry defines how [RFC 2474](https://www.rfc-editor.org/rfc/rfc2474) is to be used, while [RFC4594](https://datatracker.ietf.org/doc/html/rfc4594) defines recommended DSCPs to use for different application types. It is worth noting that some operating systems limit what DSCP values can be chosen. For example, Windows defines them for developers [this way](https://learn.microsoft.com/en-us/windows/win32/api/qos2/ne-qos2-qos_traffic_type). Therefore this allows multiple numeric DSCP values to be chosen in order to cover all operating systems and platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Add L4S/Diffserv support to Qos Profile
Which issue(s) this PR fixes:
Fixes #173
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.