Skip to content

Commit

Permalink
Data types are null when being created, defend legacy value converter…
Browse files Browse the repository at this point in the history
… from nulls
  • Loading branch information
callumbwhyte committed May 27, 2022
1 parent 71f8c3e commit cfca9e9
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
12 changes: 11 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/) and this project adheres to [Semantic Versioning](https://semver.org/).

## [3.0.3] - 2022-05-27
### Fixed
* Unable to create new Meganav properties due to null data type

## [3.0.2] - 2022-05-23
### Fixed
* `meganav-card` styles breaking backoffice minification
Expand All @@ -24,6 +28,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/) and this
* Actions to expand / collapse Meganav, and populate with all nodes from the tree
* UI overhaul with improved accessibility

## [2.0.3] - 2022-05-27
### Fixed
* Unable to create new Meganav properties due to null data type

## [2.0.2] - 2022-05-23
### Fixed
* `meganav-card` styles breaking backoffice minification
Expand Down Expand Up @@ -78,10 +86,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/) and this
### Added
* Initial release of Meganav for Umbraco 7.5

[Unreleased]: https://github.com/callumbwhyte/meganav/compare/release-3.0.2...HEAD
[Unreleased]: https://github.com/callumbwhyte/meganav/compare/release-3.0.3...HEAD
[3.0.3]: https://github.com/callumbwhyte/meganav/compare/release-3.0.2...release-3.0.3
[3.0.2]: https://github.com/callumbwhyte/meganav/compare/release-3.0.1...release-3.0.2
[3.0.1]: https://github.com/callumbwhyte/meganav/compare/release-3.0.0...release-3.0.1
[3.0.0]: https://github.com/callumbwhyte/meganav/compare/release-2.0.0...release-3.0.0
[2.0.3]: https://github.com/callumbwhyte/meganav/compare/release-2.0.2...release-2.0.3
[2.0.2]: https://github.com/callumbwhyte/meganav/compare/release-2.0.1...release-2.0.2
[2.0.1]: https://github.com/callumbwhyte/meganav/compare/release-2.0.0...release-2.0.1
[2.0.0]: https://github.com/callumbwhyte/meganav/tree/release-2.0.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ public void Handle(DataTypeSavingNotification notification)
{
var existingEntity = _dataTypeService.GetDataType(x.Id);

return existingEntity?.EditorAlias != Constants.PropertyEditorAlias && LegacyEditors.Aliases.Any(existingEntity.EditorAlias.InvariantContains);
return existingEntity != null
&& existingEntity.EditorAlias != Constants.PropertyEditorAlias
&& LegacyEditors.Aliases.Any(existingEntity.EditorAlias.InvariantContains);
});

foreach (var dataType in dataTypes)
Expand Down

0 comments on commit cfca9e9

Please sign in to comment.