Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InterruptedException log #135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lsiepel
Copy link

@lsiepel lsiepel commented Aug 30, 2024

An InterruptException should not log full stacktrace to ERROR level.

Fixes: openhab/openhab-addons#8277

Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel
Copy link
Author

lsiepel commented Dec 6, 2024

Gentle ping @bmalinowsky

@bmalinowsky
Copy link
Collaborator

@lsiepel Sorry for the delay.

Ideally, the log statement shouldn't be there at all. It is an admission to code that uses catch (all) { /* ignore */ }, is not setting appropriate log levels, nor tracing progress or reentrancy. And here, of main interest are actually interrupts (think repeated or intermingled calls, which get eventually interrupted), which would now be not traceable at all.

Unfortunately, this is also not handled in a uniform way in the other link implementations.

@lsiepel
Copy link
Author

lsiepel commented Dec 9, 2024

@lsiepel Sorry for the delay.

Ideally, the log statement shouldn't be there at all. It is an admission to code that uses catch (all) { /* ignore */ }, is not setting appropriate log levels, nor tracing progress or reentrancy. And here, of main interest are actually interrupts (think repeated or intermingled calls, which get eventually interrupted), which would now be not traceable at all.

Unfortunately, this is also not handled in a uniform way in the other link implementations.

So what do you suggest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[knx] NPE when bundle is stopped
2 participants