Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility fixes for Django 2.0 and 2.1 #146

Merged
merged 9 commits into from
Oct 26, 2019
Merged

Compatibility fixes for Django 2.0 and 2.1 #146

merged 9 commits into from
Oct 26, 2019

Conversation

PetrDlouhy
Copy link
Contributor

@PetrDlouhy PetrDlouhy commented Jan 26, 2018 •
edited
Loading

  • Fix compatibility problems with Django 2.0, add it to tests
  • allow runtests.py parameter for convenience by testing

Contains PR #145

@PetrDlouhy
Copy link
Contributor Author

@caktus @mlavin Could you please review and release the Django 2.0 fix (if you have the rights)? It is not possible to use django-scribbler from the Git repository...

@PetrDlouhy
Copy link
Contributor Author

I was forced to make my own PyPI package with Django 2.0 support (because of the #89). So if anyone is interested, here it is: https://pypi.python.org/pypi/django-scribbler-django2.0

@PetrDlouhy
Copy link
Contributor Author

@mlavin @caktus Could you please merge this? Should I help you somehow with that (explaining something, splitting this PR, ...)?

@PetrDlouhy PetrDlouhy force-pushed the Django20 branch 3 times, most recently from e09302e to fe6cd73 Compare August 30, 2018 23:20
@PetrDlouhy
Copy link
Contributor Author

@mlavin @dpoirier I have added fixes and tests also for Django 2.1. Please merge.

@PetrDlouhy PetrDlouhy changed the title Compatibility fixes for Django 2.0 Compatibility fixes for Django 2.0 and 2.1 Oct 28, 2018
@PetrDlouhy PetrDlouhy mentioned this pull request Oct 28, 2018
Closed
vkurup
vkurup approved these changes Oct 26, 2019
View reviewed changes
Copy link
Contributor

@vkurup vkurup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry to have taken so long to merge this. Thank you very much for you persistence and contribution.

@vkurup vkurup merged commit 21218e8 into caktus:master Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkurup vkurup vkurup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PetrDlouhy @vkurup @imposeren