-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New core functions: toDate and toDateTime #17743
Conversation
(Stan can't find them because they're aliased)
Switch to PHPUnit annotations for data providers Co-authored-by: ADmad <[email protected]>
I just realized also that some tests are failing on PHP8.4 specifically that are passing on 8.3 and below:
I tried work around this by simply adding Alternatively, we can remove the tests for NAN/INF and assume users will not try to pass these values to the functions, which I think is semi-reasonable. |
Language correction and remove link that no longer applies Co-authored-by: ADmad <[email protected]>
CI often has slow machines that can have a long delay between data providers and tests run.
Adds two new global functions:
toDate()
andtoDateTime()
which accept mixed values and attempt to convert them to the native Chronos object. This is the first part of a series of PRs to make type-safe request data available to users.