[Perf] Use single path for all non-image snowflakes; use for..of loops over forEach; store Math.PI * 2 as a constant #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch introduces one major and two minor performance improvements:
render()
call, instead of creating new Paths for each circular snowflake. This necessitated a slight refactor, which separates the image-based and path-based drawing routines into separate methods. The check for snowflake image presence is now only done once per render call, instead of once per snowflake. This should provide the most significant improvement on lower-end hardware and in cases with a large number of snowflakes.I'm working on supplying quantitative benchmark results, but I'm not sure of a good way to present that; if anyone has any ideas I'd love to hear them out to help get this merged!