Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of Poetry-based Virtual Environments #468

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

YanlinQi-BIA
Copy link
Contributor

@YanlinQi-BIA YanlinQi-BIA commented Nov 7, 2024

Task Background

This PR implements updates to the Oracle puller and uploader components, focusing on managing dependencies and configurations in poetry.lock and pyproject.toml.

Order of Review

  1. pyproject.toml - Updated dependencies for Oracle puller.

  2. poetry.lock - Reflects dependency updates.

  3. oracle_puller/ - Contains main logic updates for the Oracle puller.

  4. uploader/ - Contains main logic updates for the uploader.

@YanlinQi-BIA YanlinQi-BIA changed the title Create pyproject.toml Review of Poetry-based Virtual Environments Nov 8, 2024
poetry files for uploader
Copy link
Member

@ian-r-rose ian-r-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Per our discussion yesterday on writing parquet files as an intermediate format, does it make sense to also include pyarrow in the oracle_puller environment?

name = "oracle_puller_daemon"
version = "0.1.0"
description = ""
authors = ["Azam Beg <[email protected]>"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to put @pingpingxiu-DOT-ca-gov or @YanlinQi-BIA here

name = "uploader"
version = "0.1.0"
description = ""
authors = ["Your Name <[email protected]>"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@YanlinQi-BIA
Copy link
Contributor Author

This looks good to me. Per our discussion yesterday on writing parquet files as an intermediate format, does it make sense to also include pyarrow in the oracle_puller environment?

Certainly, will do.

@YanlinQi-BIA
Copy link
Contributor Author

This looks good to me. Per our discussion yesterday on writing parquet files as an intermediate format, does it make sense to also include pyarrow in the oracle_puller environment?

Certainly, will do.

pyarrow has been added to the oracle_puller environment.

@YanlinQi-BIA YanlinQi-BIA merged commit c4a909b into main Nov 20, 2024
3 checks passed
@YanlinQi-BIA YanlinQi-BIA deleted the make-use-of-virtual-env branch November 20, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants