-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review of Poetry-based Virtual Environments #468
Conversation
poetry files for uploader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Per our discussion yesterday on writing parquet files as an intermediate format, does it make sense to also include pyarrow
in the oracle_puller environment?
name = "oracle_puller_daemon" | ||
version = "0.1.0" | ||
description = "" | ||
authors = ["Azam Beg <[email protected]>"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better to put @pingpingxiu-DOT-ca-gov or @YanlinQi-BIA here
name = "uploader" | ||
version = "0.1.0" | ||
description = "" | ||
authors = ["Your Name <[email protected]>"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Certainly, will do. |
|
Task Background
This PR implements updates to the Oracle puller and uploader components, focusing on managing dependencies and configurations in
poetry.lock
andpyproject.toml
.Order of Review
pyproject.toml - Updated dependencies for Oracle puller.
poetry.lock - Reflects dependency updates.
oracle_puller/ - Contains main logic updates for the Oracle puller.
uploader/ - Contains main logic updates for the uploader.