-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 5 min clearinghouse and Detector Status Models #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… daily. Integrated the active_detectors model in the detector_agg_five_minutes model to include active detectors that were missing data.
…-pems into qc-5min-clearinghouse
kengodleskidot
requested review from
JamesSLogan,
thehanggit,
tnrahim and
mmmiah
September 27, 2024 16:29
…ro from 5-minute-agg model
JamesSLogan
approved these changes
Sep 27, 2024
...ntermediate/clearinghouse/int_clearinghouse__detector_agg_five_minutes_with_missing_rows.sql
Show resolved
Hide resolved
mmmiah
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave a comment for clarification! Otherwise looks good to me!
….sql removed a comment
…-pems into qc-5min-clearinghouse
…is used in the detector status diagnostics tests. This results in more detailed statuses when data is not being relayed from detectors. Also, reorganized joins in the detector_status model to pass PR checks.
…tector_id instead of station_id/lane.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates were made to the detector status and 5-minute agg clearinghouse models as part of QC analysis to include stations that were missing. In the detector status model, the join was updated to include the meta data before the final CTE. The 5-minute agg clearinghouse model now uses the active detectors model to capture all active detectors on a given date.