Update weighted load balancer #6522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
commented
Nov 25, 2024
| @@ -563,18 +570,7 @@ func (c *taskListManagerImpl) GetTask( | |||
| return nil, fmt.Errorf("couldn't get task: %w", err) | |||
| } | |||
| task.domainName = c.domainName | |||
| // according to Little's Law, the average number of tasks in the queue L = λW | |||
There was a problem hiding this comment.
the following code is moved to weighted load balancer
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
commented
Nov 26, 2024
| @@ -165,8 +166,8 @@ func (lb *weightedLoadBalancer) PickReadPartition( | |||
| if !ok { | |||
| return lb.fallbackLoadBalancer.PickReadPartition(domainID, taskList, taskListType, forwardedFrom) | |||
| } | |||
| p := w.pick() | |||
| lb.logger.Debug("pick read partition", tag.WorkflowDomainID(domainID), tag.WorkflowTaskListName(taskList.GetName()), tag.WorkflowTaskListType(taskListType), tag.Dynamic("weights", w.weights), tag.Dynamic("tasklist-partition", p)) | |||
There was a problem hiding this comment.
w.weights cannot be accessed without lock being held, so update the pick method to return cumulativeWeights for debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Description
Impact Analysis
Testing Plan
Rollout Plan
What?
The main purpose of this PR is to update weighted load balancer to support activity task list. A new proto type is introduced for this purpose and some refactoring is done to make the code more readable.
Test
This PR has unit tests for all components. The end-to-end tests was done manually by running workflows in dev2.