Added integration in Shard Distributor with the generated handler #6521
+598
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
reviewed
Nov 26, 2024
| matchingPeerResolver: matchingPeerResolver, | ||
| } | ||
|
|
||
| // prevent us from trying to serve requests before matching engine is started and ready |
There was a problem hiding this comment.
what is the matching engine in this context?
There was a problem hiding this comment.
@jakobht what do you think about adding an arch diagram sketch into the docs/arch folder to contextualize what you're thinking / be able to point those of us (such as myself) for whom context may have fallen out of our brains.
Adding the mapper/handler shell all seems all good, but it'd probably help with review
Shaddoll
reviewed
Nov 26, 2024
| func NewHandler( | ||
| logger log.Logger, | ||
| metricsClient metrics.Client, | ||
| matchingPeerResolver matching.PeerResolver, |
There was a problem hiding this comment.
do we need history peer resolver?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added integration of the shard distributor IDLs to the server
Why?
We need to integrate this so we can implement the endpoint
How did you test it?
Potential risks
Release notes
Documentation Changes