-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug in QueryWorkflowParameters.toString #948
Conversation
@@ -45,11 +45,6 @@ public void setInput(byte[] input) { | |||
this.input = input; | |||
} | |||
|
|||
public QueryWorkflowParameters withInput(byte[] input) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel strongly, but isn't the withX
pattern preferable to setters because it's chainable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right but they are currently unused though
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Continue to review full report in Codecov by Sentry.
|
What changed?
Why?
part of unit test coverage
How did you test it?
unit test
Potential risks
Release notes
Documentation Changes