Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in QueryWorkflowParameters.toString #948

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

shijiesheng
Copy link
Contributor

@shijiesheng shijiesheng commented Nov 6, 2024

What changed?

  • Fixed a bug that toString will error if input length is smaller than 512
  • remove unused method (with method has been replaced with setter already)
  • add test coverage

Why?
part of unit test coverage

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

@@ -45,11 +45,6 @@ public void setInput(byte[] input) {
this.input = input;
}

public QueryWorkflowParameters withInput(byte[] input) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly, but isn't the withX pattern preferable to setters because it's chainable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right but they are currently unused though

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@d4b2d0b). Learn more about missing BASE report.
Report is 10 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
...dence/internal/replay/QueryWorkflowParameters.java 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b2d0b...70f81a0. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2622

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 617 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-3.0%) to 76.159%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/common/RetryParameters.java 1 82.69%
src/main/java/com/uber/cadence/internal/compatibility/thrift/Helpers.java 1 62.5%
src/main/java/com/uber/cadence/internal/compatibility/thrift/HistoryMapper.java 9 98.02%
src/main/java/com/uber/cadence/internal/replay/StartChildWorkflowExecutionParameters.java 27 69.32%
src/main/java/com/uber/cadence/internal/compatibility/thrift/ErrorMapper.java 30 0.0%
src/main/java/com/uber/cadence/internal/compatibility/thrift/ResponseMapper.java 159 30.43%
src/main/java/com/uber/cadence/internal/logging/ReplayAwareLogger.java 174 6.95%
src/main/java/com/uber/cadence/internal/compatibility/thrift/TypeMapper.java 216 24.51%
Totals Coverage Status
Change from base Build 2619: -3.0%
Covered Lines: 14755
Relevant Lines: 19374

💛 - Coveralls

@shijiesheng shijiesheng merged commit b5d8ef8 into cadence-workflow:master Nov 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants