Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for ContinueAsNewWorkflowExecutionParameters #947

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Nov 6, 2024

What changed?

  • Add unit tests for ContinueAsNewWorkflowExecutionParameters
  • Fix some bugs in ContinueAsNewWorkflowExecutionParameters

Why?
improve unit test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (6d76d41) to head (5dafc0b).
Report is 3 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
...play/ContinueAsNewWorkflowExecutionParameters.java 100.00% <100.00%> (+57.89%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b08b8d7...5dafc0b. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 6, 2024

Pull Request Test Coverage Report for Build 2627

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 79.596%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/sync/CancellationScopeImpl.java 1 92.65%
src/main/java/com/uber/cadence/internal/replay/ReplayDecider.java 5 80.27%
Totals Coverage Status
Change from base Build 2625: 0.09%
Covered Lines: 15440
Relevant Lines: 19398

💛 - Coveralls

@Shaddoll Shaddoll merged commit 1d0e355 into master Nov 7, 2024
14 checks passed
@Shaddoll Shaddoll deleted the continue branch November 7, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants