Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in RetryParameters and add unit tests to ExecuteActivityParameters #946

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented Nov 6, 2024

What changed?
Fix NPE in RetryParameters and add unit tests to ExecuteActivityParameters

Why?
Fix an edge case where set function could result in NPE
Improve unit test coverage

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.61%. Comparing base (aa86d2a) to head (c487f8b).
Report is 9 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
.../uber/cadence/internal/common/RetryParameters.java 100.00% <100.00%> (+15.38%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa86d2a...c487f8b. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 6, 2024

Pull Request Test Coverage Report for Build 2624

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 175 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 78.371%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/testservice/TestWorkflowMutableStateImpl.java 1 85.56%
src/main/java/com/uber/cadence/internal/logging/ReplayAwareLogger.java 174 6.95%
Totals Coverage Status
Change from base Build 2617: -0.7%
Covered Lines: 15197
Relevant Lines: 19391

💛 - Coveralls

@timl3136 timl3136 merged commit f609320 into cadence-workflow:master Nov 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants