Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unimplementented methods of TestWorkflowEnvironment #945

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

shijiesheng
Copy link
Contributor

What changed?

  • Fixed unsupported methods of TestWorkflowEnvironment to throw unsupported exception
  • Added unit test coverage for all unsupported method as well

Why?
part of unit test coverage

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@d4b2d0b). Learn more about missing BASE report.
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...internal/sync/TestWorkflowEnvironmentInternal.java 0.00% 6 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...ence/internal/testservice/TestWorkflowService.java 80.20% <100.00%> (ø)
...internal/sync/TestWorkflowEnvironmentInternal.java 53.24% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b2d0b...d9b2408. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2616

Details

  • 4 of 10 (40.0%) changed or added relevant lines in 2 files are covered.
  • 414 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.0%) to 76.181%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/uber/cadence/internal/sync/TestWorkflowEnvironmentInternal.java 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/sync/CancellationScopeImpl.java 1 92.65%
src/main/java/com/uber/cadence/internal/common/RetryParameters.java 1 82.69%
src/main/java/com/uber/cadence/internal/compatibility/thrift/Helpers.java 1 62.5%
src/main/java/com/uber/cadence/internal/compatibility/thrift/HistoryMapper.java 9 98.02%
src/main/java/com/uber/cadence/internal/replay/StartChildWorkflowExecutionParameters.java 27 69.32%
src/main/java/com/uber/cadence/internal/compatibility/thrift/ResponseMapper.java 159 30.43%
src/main/java/com/uber/cadence/internal/compatibility/thrift/TypeMapper.java 216 24.51%
Totals Coverage Status
Change from base Build 2612: -2.0%
Covered Lines: 14770
Relevant Lines: 19388

💛 - Coveralls

@shijiesheng shijiesheng merged commit 6d76d41 into cadence-workflow:master Nov 6, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants