Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WorkflowQueue#offer and increase test coverage #932

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

natemort
Copy link
Member

What changed?

  • WorkflowQueue#offer is misinterpreting the return value of WorkflowThread.await, resulting in it returning false whenever it can add an element to the queue or throwing an exception whenever it can't and the operation times out.
  • Added additional test coverage for CompletablePromise

Why?

  • Fix existing functionality

How did you test it?

  • Unit tests.

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.06%. Comparing base (c04bf6b) to head (852966c).
Report is 1 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
.../uber/cadence/internal/sync/WorkflowQueueImpl.java 86.04% <100.00%> (+62.79%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04bf6b...852966c. Read the comment docs.

@natemort natemort merged commit fa60a85 into cadence-workflow:master Oct 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants