Report child workflow started synchronously (#928)

By reporting child workflow started asynchronously we can observe a child workflow attempting to complete prior to its state machine registering that it started. This is an invalid state transition and causes test failures. See temporalio/sdk-java#1289 , we have the same test case still and it has similarly been flakey.
cadence-workflow · Oct 29, 2024 · c04bf6b · c04bf6b
1 parent dc0f0c4
commit c04bf6b
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/src/main/java/com/uber/cadence/internal/testservice/TestWorkflowMutableStateImpl.java b/src/main/java/com/uber/cadence/internal/testservice/TestWorkflowMutableStateImpl.java
@@ -1179,17 +1179,13 @@ public void startWorkflow(
               .setWorkflowExecution(getExecutionId().getExecution())
               .setDomain(getExecutionId().getDomain())
               .setWorkflowType(startRequest.getWorkflowType());
-      ForkJoinPool.commonPool()
-          .execute(
-              () -> {
-                try {
-                  parent.get().childWorkflowStarted(a);
-                } catch (EntityNotExistsError | WorkflowExecutionAlreadyCompletedError e) {
-                  // Not a problem. Parent might just close by now.
-                } catch (BadRequestError | InternalServiceError e) {
-                  log.error("Failure reporting child completion", e);
-                }
-              });
+      try {
+        parent.get().childWorkflowStarted(a);
+      } catch (EntityNotExistsError | WorkflowExecutionAlreadyCompletedError e) {
+        // Not a problem. Parent might just close by now.
+      } catch (BadRequestError | InternalServiceError e) {
+        log.error("Failure reporting child completion", e);
+      }
     }
   }