Color Example + Android Animation Improvement #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TomCarey
commented
Dec 3, 2024
TomCarey
commented
- Added an example for theming each screen on transition
- Improved status bar color changes by introducing an animated value
Our push and pops are animated by default so we should also animate the status bar color change to go with it. 300L is the default android animation length
|
Watching the animations frame by frame I'm noticing there is perhaps an over complication where we might not be needing to set the status bar color at all which, if true, would allow the animator for the navigation to be the driving factor so that transitions with or without animation look perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.