Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable fade transition #33

Merged
merged 1 commit into from
Jan 30, 2021

Conversation

Dreamescaper
Copy link
Contributor

As agreed in #30, removed fade transition, which allowed me to use AerielDream on my Sony TV.

@Dreamescaper Dreamescaper marked this pull request as draft January 29, 2021 17:43
@Dreamescaper Dreamescaper marked this pull request as ready for review January 29, 2021 17:48
Copy link
Owner

@cachapa cachapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I just the one remark about the change to a SurfaceView, otherwise it looks good.

@cachapa cachapa merged commit fc2fbec into cachapa:master Jan 30, 2021
@Dreamescaper Dreamescaper deleted the disable_fade_transition branch January 30, 2021 12:32
@JBallin
Copy link

JBallin commented Jan 31, 2021

Thank you both for fixing this! 4k works on my tv now (playback is smooth - had choppiness before, and the transitions work just fine - flashes a black screen) 🎉

I have just 1 other issue with the app, that I was hopeful would be fixed as part of #30 - but it's still not working unfortunately - opened #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants