Skip to content

Commit

Permalink
Merge pull request #19 from cabify/use-shorter-list-of-buckets-as-def…
Browse files Browse the repository at this point in the history
…ault

Shorten default list of buckets
  • Loading branch information
Simon Sargeant authored Jun 5, 2019
2 parents a84f0ad + 3e79567 commit b6bf805
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.2.1] - 2019-06-05
### Changed
- Reduced the number of default buckets from 12 to 7 between 0.05s and 10s

## [0.2.0] - 2019-05-20
### Fixed
- Included the implementation builder for summaries [#14](https://github.com/cabify/gotoprom/pull/14)
- Included the implementation builder for summaries [#14](https://github.com/cabify/gotoprom/pull/14)

## [0.1.1] - 2019-05-08
### Fixed
Expand Down
2 changes: 1 addition & 1 deletion prometheusvanilla/builders.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func bucketsFromTag(tag reflect.StructTag) ([]float64, error) {

// DefaultBuckets provides a list of buckets you can use when you don't know what to use yet.
func DefaultBuckets() []float64 {
return []float64{.005, .01, .025, .05, .1, .25, .5, 1, 2.5, 5, 10, 25}
return []float64{.05, .1, 0.25, .5, 1, 5, 10}
}

func maxAgeFromTag(tag reflect.StructTag) (time.Duration, error) {
Expand Down

0 comments on commit b6bf805

Please sign in to comment.