Custom sample filtering performance and security improvement #11241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dippindots
commented
Nov 29, 2024
Comment on lines
+99
to
+101
| <if test="sampleIdentifier.getUniqueSampleId != null"> | ||
| #{sampleIdentifier.getUniqueSampleId} | ||
| </if> |
There was a problem hiding this comment.
I'm not sure if adding test at here will break anything. maybe we need to add another '', at here like we did in line 85. Maybe @gblaih can comment on this.
There was a problem hiding this comment.
there is a case if getUniqueSampleId is null for all customDataSamples, it will break since we cannot do NOT IN (). adding '' will prevent it from breaking, but it may cause unintended issues with the logic i think. is there a case where the custom samples have null studyIds and sampleIds?
…ve array to improve performance
alisman
force-pushed
the
demo-fix-prepared-statements
branch
from
b8bf026
to
871510b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11195