-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClickHouse-Only cBioPortal Demo based on standard schema #10839
Open
sheridancbio
wants to merge
10
commits into
master
Choose a base branch
from
demo-clickhouse-poc-uppercase-columnnames
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- table names in mybatis mappers standardized to lower case only - SQL format bugs fixed (such as 'ONSAMPLE.PATIENT_ID' -> 'ON sample.PATIENT_ID' - SQL keywords captitalized where noticed - comment out password setting to allow use of local redis - some whitespace standardization included in AlterationCountsMapper.xml
- whitespace changes to AlterationCountsMapper.xml not separate from lowercasing of fields
- also partial progress (to rendering of home page) fixing remaining GROUP BY issues
- format SQL IN list clauses with minimal whitespace - attempt at debugging AlterationCountMapper (incomplete) - fix some missed case conversions (to all lower case fields and tables)
sheridancbio
force-pushed
the
demo-clickhouse-poc-uppercase-columnnames
branch
4 times, most recently
from
August 22, 2024 00:50
9bbb691
to
f5cad33
Compare
put placeholder in migration.sql and make db version consistent
sheridancbio
force-pushed
the
demo-clickhouse-poc-uppercase-columnnames
branch
from
August 22, 2024 00:55
f5cad33
to
eab18ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adapts the cBioPortal production codebase for direct use with a ClickHouse deployed database. This is to demonstrate and explore the feasibility of eliminating the mySQL dependency entirely as part of our adoption of OLAP based tools.
Describe changes proposed in this pull request:
Known issues and remaining work
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>
to determine thatand notify them either through slack or by assigning them as a reviewer on the PR