This repository has been archived by the owner on Apr 6, 2021. It is now read-only.
Process kill fix #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disabled when ace is not opened? * Watchers shouldn't have multiple watchers for the same path * Watchers should ignore .c9config
| @@ -124,6 +126,11 @@ function Consumer() { | |||
| proxyApi.emit("error", err); | |||
| }); | |||
| }); | |||
|
|
|||
| this.on("error", function(err){ | |||
There was a problem hiding this comment.
This was annoying me sometimes with collab, good that you handled it here
| @@ -59,6 +63,7 @@ function Worker(vfs) { | |||
| watch: route("watch"), | |||
| connect: route("connect"), | |||
| spawn: route("spawn"), | |||
| pty: route("pty"), | |||
There was a problem hiding this comment.
doesn't this require c9/vfs-local#11 to be merged as well ?
There was a problem hiding this comment.
It doesn't matter unless the method is called.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fjakobs @lennartcl @mostafaeweda
Sadly, this PR contains all the changes I've made during the course of working on newclient. The important one is the process kill fix. This is achieved by moving streams to the bottom:
https://github.com/c9/vfs-socket/pull/7/files#L2L110