Fix: Exporter could report success eventhough metrics are missing (#90)

c4po · Mar 23, 2021 · 36511d2 · 36511d2
1 parent 7859625
commit 36511d2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/harbor_exporter.go b/harbor_exporter.go
@@ -372,7 +372,7 @@ func (h *HarborExporter) Collect(outCh chan<- prometheus.Metric) {
 		ok = h.collectReplicationsMetric(samplesCh) && ok
 	}
 	if collectMetricsGroup[metricsGroupSystemInfo] {
-		ok = h.collectSystemMetric(samplesCh)
+		ok = h.collectSystemMetric(samplesCh) && ok
 	}
 	if collectMetricsGroup[metricsGroupArtifactsInfo] {
 		ok = h.collectArtifactsMetric(samplesCh) && ok