Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new LTag aliases: C# and V# for crag climbing routes #1860

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bohwaz
Copy link

@bohwaz bohwaz commented Aug 24, 2024

This commit adds two new syntaxes for tables of lines, intended for use with crag climbing routes:

V#1 | Name A | 6a+
C#2 | Name B | 5b

V is for "Voie", C is for "Climb", as R (could be used for Route) is already used for "Relay" and L (could mean "Line") is used for "Longueur".

When transformed to HTML, the V or C is removed, resulting in this:

- - -
1 Name A 6a+
2 Name B 5b

(Table header added here to make it work with Github markdown syntax)

Apart from this, there is no difference with the handling of regular R# and L# tags.

This is useful for writing topos for regular crags, where a climb can have multiple lengths (longueurs) and relays. It's closer to what you would find in topo guidebooks.

I added a new test to make sure the aliases work properly.

@bohwaz
Copy link
Author

bohwaz commented Sep 30, 2024

Anyone interested to merge this?

@cbeauchesne
Copy link
Member

cbeauchesne commented Oct 1, 2024

Hi @bohwaz ,

Thanks for your work. I've approved the PR, as the original writer of this extension to confirm that your work is fine from a technical POV.

Though, I'm not anymore part of c2c anymore, so I can't make the decision to merge it. You can send a message to the developper forum on c2c to get someone to merge it if nobody answers here.

Best!

@bohwaz
Copy link
Author

bohwaz commented Oct 1, 2024

Thank you @cbeauchesne I'll do that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants