feat: c2corg#1067 add public transport information in routes #1797
Conversation
Nayor
force-pushed
the
feat/#1067-add-public-transport-information-in-routes
branch
from
3dcb75f to
7198562
Compare
|
xref #1067 and c2corg/c2c_ui#3936 for frontend |
| @@ -282,3 +312,206 @@ def set_title_prefix_for_ids(ids, title): | |||
| """ | |||
| DBSession.query(RouteLocale).filter(RouteLocale.id.in_(ids)). \ | |||
| update({RouteLocale.title_prefix: title}, synchronize_session=False) | |||
|
|
|||
|
|
|||
| def update_all_pt_rating(waypoint_extrapolation=True): | |||
There was a problem hiding this comment.
a bit worried about using the ORM for such a giant query... best way to run this would be in batches ?
There was a problem hiding this comment.
@eddy-geek
The first request runs in 3209.054 ms on my laptop
The whole process is done in a few minutes and is supposed to be used only once, afterwards the informations are supposed to be automaticaly updated on route/waypoint creation/updates
With python log level = INFO and postgresql log level to all, the whole process took about 2-3 hours on my laptop and generates huge amount of logs (since that for each route, every linked waypoints are read and the route updated)
There was a problem hiding this comment.
May be the best is to not expose this function to the REST API and run it with a command line ? So only devs can run it
There was a problem hiding this comment.
did you run your tests on the full production database?
if it's just a one-time migration then yes we should not leave it in the API, but I guess it's ok to leave it as-is for now and remove the API part after we're done with the initial migration
There was a problem hiding this comment.
I have run the tests on the docker's image data, I don't have access to the production data
The other way to make the migration is to call the function using a python command
Nayor
force-pushed
the
feat/#1067-add-public-transport-information-in-routes
branch
from
7198562 to
51bd9c6
Compare
Nayor
force-pushed
the
feat/#1067-add-public-transport-information-in-routes
branch
from
51bd9c6 to
af19ddd
Compare
Nayor
changed the title
No description provided.